-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move RTE feature flag to settings #1703
Conversation
Generated by 🚫 Danger Swift against 4a6a3b2 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1703 +/- ##
===========================================
- Coverage 58.41% 58.24% -0.17%
===========================================
Files 425 425
Lines 28690 28650 -40
Branches 14254 14231 -23
===========================================
- Hits 16759 16687 -72
- Misses 11486 11523 +37
+ Partials 445 440 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
d1f1d0c
to
2cd87f2
Compare
2ecc62b
to
4a6a3b2
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works great! 👏
…n the Rich Text Editor one is disabled (advanced settings) - this basically reverts parts of #1703
This PR:
MessageComposerTextField
The PR doesn't include:
RTE Off
off.mp4
RTE On
on.mp4