Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RTE feature flag to settings #1703

Merged
merged 5 commits into from
Sep 14, 2023

Conversation

alfogrillo
Copy link
Contributor

@alfogrillo alfogrillo commented Sep 13, 2023

This PR:

  • Updates matrix-wysiwyg-composer-swift to 2.10.1
  • Deletes completely the old MessageComposerTextField
  • Sends the markdown formatted text when the RTE setting is off

The PR doesn't include:

  • The update of the ui tests (more changes in the design will follow)
  • The update of the UX for the reply/edit flow (it stays the same for now)

RTE Off

off.mp4

RTE On

on.mp4

@github-actions
Copy link

github-actions bot commented Sep 13, 2023

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 4a6a3b2

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 27.77% and project coverage change: -0.17% ⚠️

Comparison is base (24524a6) 58.41% compared to head (4a6a3b2) 58.24%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1703      +/-   ##
===========================================
- Coverage    58.41%   58.24%   -0.17%     
===========================================
  Files          425      425              
  Lines        28690    28650      -40     
  Branches     14254    14231      -23     
===========================================
- Hits         16759    16687      -72     
- Misses       11486    11523      +37     
+ Partials       445      440       -5     
Flag Coverage Δ
unittests 22.76% <27.77%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
ElementX/Sources/Application/AppSettings.swift 96.55% <ø> (ø)
...Screens/ComposerToolbar/View/ComposerToolbar.swift 64.61% <0.00%> (-1.04%) ⬇️
...Screens/ComposerToolbar/View/MessageComposer.swift 40.22% <0.00%> (-9.53%) ⬇️
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 57.66% <0.00%> (+0.15%) ⬆️
...cedOptionsScreen/View/AdvancedSettingsScreen.swift 0.00% <ø> (ø)
...ens/ComposerToolbar/ComposerToolbarViewModel.swift 66.20% <80.00%> (+0.42%) ⬆️
...creens/ComposerToolbar/ComposerToolbarModels.swift 93.43% <100.00%> (-0.24%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alfogrillo alfogrillo force-pushed the alfogrillo/rework-rte-feature-flag branch from d1f1d0c to 2cd87f2 Compare September 14, 2023 08:08
@alfogrillo alfogrillo mentioned this pull request Sep 14, 2023
@alfogrillo alfogrillo force-pushed the alfogrillo/rework-rte-feature-flag branch from 2ecc62b to 4a6a3b2 Compare September 14, 2023 10:27
@alfogrillo alfogrillo marked this pull request as ready for review September 14, 2023 10:27
@alfogrillo alfogrillo requested a review from a team as a code owner September 14, 2023 10:27
@alfogrillo alfogrillo requested review from Velin92 and removed request for a team September 14, 2023 10:27
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great! 👏

@alfogrillo alfogrillo merged commit 058fe79 into develop Sep 14, 2023
@alfogrillo alfogrillo deleted the alfogrillo/rework-rte-feature-flag branch September 14, 2023 11:10
stefanceriu added a commit that referenced this pull request Apr 15, 2024
…n the Rich Text Editor one is disabled (advanced settings)

- this basically reverts parts of #1703
stefanceriu added a commit that referenced this pull request Apr 15, 2024
#2696)

* Bring back the original native `MessageComposerTextField`, use it when the Rich Text Editor one is disabled (advanced settings)
- this basically reverts parts of #1703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants