Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When the RTE is enabled, the plain body contains escaped characters. #1629

Closed
pixlwave opened this issue Sep 5, 2023 · 4 comments
Closed

When the RTE is enabled, the plain body contains escaped characters. #1629

pixlwave opened this issue Sep 5, 2023 · 4 comments
Assignees
@kittykat
Labels
A-Rich-Text-Editor O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Team: Element X Feature

Comments

@pixlwave
Copy link
Member

pixlwave commented Sep 5, 2023

Steps to reproduce

  1. Enable the RTE in developer options
  2. Send the message Really?
  3. Inspect the event.

Outcome

What did you expect?

"body": "Really?"

The plain body should be untouched and sent exactly as the user input (maybe other than trimming leading/trailing whitespaces).

What happened instead?

"body": "Really\?"

Your phone model

No response

Operating system version

16.6

Application version

1.2.9 Nightly

Homeserver

No response

Will you send logs?

No
@pixlwave pixlwave mentioned this issue Sep 5, 2023
Closed
@Velin92 Velin92 added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Rich-Text-Editor labels Sep 5, 2023
@kittykat kittykat mentioned this issue Sep 8, 2023
Closed
This was referenced Sep 11, 2023
Closed
Closed
Closed
@jonnyandrew jonnyandrew mentioned this issue Sep 11, 2023
Closed
@stefanceriu
Copy link
Member

Seems the problem stems from inside the Wysiwig model:

(lldb) po model.getContentAsHtml()
"Really?"

(lldb) po model.getContentAsMarkdown()
"Really\\?"

(lldb) po model.getContentAsPlainText()
"Really?"

@jplatte
Copy link
Contributor

jplatte commented Sep 12, 2023

So why would we put markdown in the plain-text body?

@langleyd
Copy link
Member

This should be fixed now

@jonnyandrew
Copy link

Fixed by #1703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kittykat kittykat

Labels
A-Rich-Text-Editor O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Team: Element X Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@kittykat @stefanceriu @jplatte @jonnyandrew @pixlwave @langleyd @Velin92