Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable allRoomsView #398

Closed
Tracked by #428
manuroe opened this issue Jan 3, 2023 · 2 comments
Closed
Tracked by #428

Enable allRoomsView #398

manuroe opened this issue Jan 3, 2023 · 2 comments
Labels
A-Room-List T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements T-User Story Team: Element X Platform X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue Z-BBQ-Beta Required for ElementX - BBQ - Beta

Comments

@manuroe
Copy link
Member

manuroe commented Jan 3, 2023

here

It will improve several things:

We should enable it only if it works.
We can probably tweak some values. I used 100 for the batch size and 30 for timelineLimit with good results.

@manuroe manuroe added Z-BBQ-Beta Required for ElementX - BBQ - Beta A-Room-List T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements TF:0 labels Jan 3, 2023
@manuroe
Copy link
Member Author

manuroe commented Jan 4, 2023

Done in #400.
#396 is left open unfortunately.

@manuroe manuroe closed this as completed Jan 4, 2023
@manuroe
Copy link
Member Author

manuroe commented Jan 5, 2023

We disabled it as the AllRooms view kills timeline updates and e2ee performance on large account but it seems to be fine for smaller one (< 1k rooms).

@manuroe manuroe reopened this Jan 5, 2023
@manuroe manuroe added the X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-List T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements T-User Story Team: Element X Platform X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue Z-BBQ-Beta Required for ElementX - BBQ - Beta
Projects
None yet
Development

No branches or pull requests

3 participants