Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holes in the room list #396

Closed
manuroe opened this issue Jan 3, 2023 · 6 comments
Closed

Holes in the room list #396

manuroe opened this issue Jan 3, 2023 · 6 comments
Assignees
Labels
A-Room-List T-Defect Z-BBQ-Beta Required for ElementX - BBQ - Beta

Comments

@manuroe
Copy link
Member

manuroe commented Jan 3, 2023

Some holes can appear when scrolling in the room list. There are of 2 types. We can have blank cells or default placeholders:

IMG_5164

Note there is a 3rd type of hole. When the allRoomsView is enabled, some rooms can hide and show when scrolling slowly. I can share a video in a private matrix room.

@stefanceriu
Copy link
Member

This is still happening, on "filled" rooms as it seems. Needs more debuggin, reopening.

@stefanceriu stefanceriu reopened this Jan 18, 2023
@stefanceriu
Copy link
Member

Tracked this down to a RustSDK problem in which the pos query param isn't incremented correct and list diff operations are applied multiple times, which can create duplicates in both filled and invalidated rooms.

@stefanceriu
Copy link
Member

We have worked around this client side here but the underlying issue still remains. I've added a lot more logging around the issue to at least give us an idea what to look for. The problem here is that it's reproducible but very hard to track down exactly why it happens and on what level

@stefanceriu
Copy link
Member

We haven't seen this for quite some time now so let's close it but leave the duplication detection logging in just in case. This will all be improved anyway when merging lists directly on the rust side

@ara4n
Copy link
Member

ara4n commented Jul 8, 2023

This came back with a vengance in the week before the public launch of EX, so reopening it. It looks like this sort of thing (from June 30th Nightly):

image

@ara4n ara4n reopened this Jul 8, 2023
@ara4n
Copy link
Member

ara4n commented Jul 8, 2023

actually, i guess this is now #1157

@ara4n ara4n closed this as completed Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-List T-Defect Z-BBQ-Beta Required for ElementX - BBQ - Beta
Projects
None yet
Development

No branches or pull requests

3 participants