Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] RTE Plain/Markdown text mode on EX #1936

Closed
3 tasks done
Tracked by #1940
langleyd opened this issue Jul 27, 2023 · 1 comment
Closed
3 tasks done
Tracked by #1940

[Story] RTE Plain/Markdown text mode on EX #1936

langleyd opened this issue Jul 27, 2023 · 1 comment
Assignees
Labels
A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor App: ElementX Android App: ElementX iOS T-User Story Team: Element X Feature X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA

Comments

@langleyd
Copy link
Member

langleyd commented Jul 27, 2023

Description

  • As a user
  • I want to be able to able to enter plain text/markdown in the editor
  • so that I can send simple messages to other room members

Size estimate

M

Dependencies

Acceptance criteria

  • New option in developer settings
    • (default) When enabled, rich text formatting menu is available and markdown is disabled
    • When disabled, rich text formatting menu is not available and markdown is enabled
  • When markdown is enabled (i.e. rich text formatting setting is disabled):
    • Plain text and markdown can be entered into the composer
    • The send button is enabled accordingly
    • Reply mode works
    • Editing a message works
      • When editing a message, the composer is populated with the plain text body of the original message
    • The message can be send and the formatting from the markdown is rendered correctly and message content sent is correctly formatted.
  • Under the hood, the editor is always the Matrix Rich Text Editor (as opposed to a basic text field)

Examples

Feature flag state User types Expected body Expected formatted_body
Enabled **Hello** **Hello** **Hello**
Enabled Hello Hello Hello
Disabled **Hello** **Hello** <p><strong>Hello</strong></p>\n
Disabled Hello Hello undefined

Technical details

Feature flag state Source of body Source of formatted_body
Enabled Output of RTE (from getMessageMarkdown()) Output of RTE (from getMessageHtml())
Disabled Output of RTE (from getMessageMarkdown()) Generated by Matrix Rust SDK (from messageEventContentFromMarkdown()

Out of scope

  • Mentions/Slash Commands

Sign-off

Android

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion

iOS

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion

Subtasks

Android

Preview Give feedback

iOS

Preview Give feedback
  1. alfogrillo
  2. alfogrillo

Other

Preview Give feedback
No tasks being tracked yet.
@langleyd langleyd changed the title [Story] RTE, Plain/Markdown text mode [Story] RTE Plain/Markdown text mode on EX Jul 27, 2023
@jonnyandrew
Copy link

jonnyandrew commented Jul 31, 2023

Closing as not done (out of scope)

@jonnyandrew jonnyandrew reopened this Sep 12, 2023
@langleyd langleyd added the X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA label Sep 19, 2023
@jonnyandrew jonnyandrew added the A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor App: ElementX Android App: ElementX iOS T-User Story Team: Element X Feature X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA
Projects
None yet
Development

No branches or pull requests

4 participants