Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication: Support server provisioning links #6180

Closed
Tracked by #5151
pixlwave opened this issue May 18, 2022 · 0 comments · Fixed by #6250
Closed
Tracked by #5151

Authentication: Support server provisioning links #6180

pixlwave opened this issue May 18, 2022 · 0 comments · Fixed by #6250
Assignees
Labels
A-Authentication T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-FTUE Issue is relevant to the first time use project or experience

Comments

@pixlwave
Copy link
Member

pixlwave commented May 18, 2022

The new authentication service doesn't yet support server provisioning links like the current one does. There are 2 types that we currently support:

Ideally this should be simpler than the current set up as we can send them directly to the AuthenticationService and cut out the round trip made through the delegate/tabbar/coordinators etc. The service can then either pre-configure itself ready for display if we're still showing onboarding screens, otherwise using an AuthenticationServiceDelegate delegate method to inform the AuthenticationCoordinator to either update/prompt the user.

Ideally this change of messaging can be adopted in the LegacyAuthenticationCoordinator too as the current configuration on that breaks the coordinator pattern somewhat.

@pixlwave pixlwave changed the title Server provisioning links Authentication: Support server provisioning links May 18, 2022
@pixlwave pixlwave added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-FTUE Issue is relevant to the first time use project or experience A-Authentication labels May 18, 2022
@ismailgulek ismailgulek self-assigned this Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Authentication T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-FTUE Issue is relevant to the first time use project or experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants