Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTUE: Support server provisioning links #6250

Merged
merged 9 commits into from
Jun 7, 2022
Merged

FTUE: Support server provisioning links #6250

merged 9 commits into from
Jun 7, 2022

Conversation

ismailgulek
Copy link
Contributor

Fixes #6180

@ismailgulek ismailgulek requested a review from pixlwave June 7, 2022 13:21
@github-actions
Copy link

github-actions bot commented Jun 7, 2022 •
edited
Loading

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/CtSb8C

pixlwave
pixlwave reviewed Jun 7, 2022
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good 😎

Those changes to UniversalLink make it so much nicer 👏

RiotSwiftUI/Modules/Authentication/Common/Service/MatrixSDK/AuthenticationService.swift Show resolved Hide resolved
Riot/Utils/UniversalLink.m Outdated Show resolved Hide resolved
Riot/Utils/UniversalLink.h Show resolved Hide resolved
Riot/Modules/Onboarding/AuthenticationCoordinator.swift Outdated Show resolved Hide resolved
@ismailgulek ismailgulek requested a review from pixlwave June 7, 2022 16:49
pixlwave
pixlwave approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

@ismailgulek ismailgulek merged commit ceae4a4 into develop Jun 7, 2022
@ismailgulek ismailgulek deleted the ismail/6180_support_prov_links branch June 7, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Authentication: Support server provisioning links
2 participants
@ismailgulek @pixlwave