Adds Space List Bottom Sheet #6749

ericdecanini · 2022-08-05T14:11:08Z

Type of change

Feature
Bugfix
Technical
Other :

Content

Adds Space List Bottom Sheet

Motivation and context

Closes #6499

Not included in this PR:

Known bugs to be addressed separately:

Sometimes the bottom sheet opens with the wrong size

Screenshots / GIFs

	Before	After
Light
Dark
Black

Video:

spaceswitching2.mp4

Tests

Enable the New App Layout feature flag
Click on the open spaces FAB
See the bottom sheet and try navigating between spaces
There is a known bug where the bottom sheet doesn't always measure properly. This will be addressed in TBA

Tested devices

Physical
Emulator
OS version(s): Android 12

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

…-list-modal

…Sheet class name

…eader

…-list-modal # Conflicts: # vector/src/main/java/im/vector/app/features/home/NewHomeDetailFragment.kt

…re/eric/space-list-modal # Conflicts: # vector/src/main/java/im/vector/app/features/home/room/list/home/HomeRoomListFragment.kt

fedrunov

Looks good, but with some comments

fedrunov · 2022-08-09T08:59:18Z

changelog.d/6749.feature

@@ -0,0 +1 @@
+Adds space list bottom sheet for new app layout


do we need to provide changelog for features which are not accessible yet?

we should them but they should be .wip

fedrunov · 2022-08-09T08:59:33Z

vector/src/main/java/im/vector/app/features/grouplist/NewHomeSpaceSummaryItem.kt

+        holder.name.text = holder.view.context.getString(R.string.all_chats)
+        holder.root.isChecked = selected
+        holder.root.context.resources
+        holder.avatar.background = ContextCompat.getDrawable(holder.view.context, R.drawable.new_space_home_background)


isn't it better to set it in xml?

No because we use the same XML for NewSpaceSummaryItem where we don't want to have this background

fedrunov · 2022-08-09T09:01:10Z

vector/src/main/java/im/vector/app/features/grouplist/NewHomeSpaceSummaryItem.kt

+        holder.root.context.resources
+        holder.avatar.background = ContextCompat.getDrawable(holder.view.context, R.drawable.new_space_home_background)
+        holder.avatar.backgroundTintList = ColorStateList.valueOf(
+                ColorUtils.setAlphaComponent(ThemeUtils.getColor(holder.view.context, R.attr.vctr_content_tertiary), (255 * 0.3).toInt()))


better to move to xml resource, both declaration of color state and setting it as backgroundTintList

Same as above

fedrunov · 2022-08-09T09:02:22Z

vector/src/main/java/im/vector/app/features/home/NewHomeDetailFragment.kt

@@ -337,7 +338,8 @@ class NewHomeDetailFragment @Inject constructor(
            if (fragmentToShow == null) {
                when (tab) {
                    is HomeTab.RoomList -> {
-                        add(R.id.roomListContainer, HomeRoomListFragment::class.java, null, fragmentTag)
+                        val params = RoomListParams(tab.displayMode)


we don't need any param for HomeRoomListFragment

fedrunov · 2022-08-09T12:10:14Z

changelog.d/6749.feature

@@ -0,0 +1 @@
+Adds space list bottom sheet for new app layout


I don't think we need to provide changelogs for features, which are not accessible for users 🤔

# Conflicts: # vector/src/main/res/layout/fragment_room_list.xml

…-list-modal # Conflicts: # vector/src/main/java/im/vector/app/features/home/room/list/home/HomeRoomListFragment.kt

fedrunov

LGTM

ElementBot · 2022-08-16T10:59:27Z

vector/src/main/res/layout/fragment_room_list.xml

+            android:layout_gravity="bottom|end"
+            android:layout_marginEnd="16dp"
+            android:layout_marginBottom="16dp"
+            android:accessibilityTraversalBefore="@id/roomListView"


⚠️ Attribute accessibilityTraversalBefore is only used in API level 22 and higher (current min is 21)

⚠️ Attribute accessibilityTraversalBefore is only used in API level 22 and higher (current min is 21)

ElementBot · 2022-08-16T10:59:27Z

vector/src/main/res/layout/fragment_room_list.xml

            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
+            android:layout_gravity="bottom|end"
            android:layout_marginEnd="16dp"
            android:layout_marginBottom="16dp"
            android:accessibilityTraversalBefore="@id/roomListView"


⚠️ Attribute accessibilityTraversalBefore is only used in API level 22 and higher (current min is 21)

⚠️ Attribute accessibilityTraversalBefore is only used in API level 22 and higher (current min is 21)

ElementBot · 2022-08-16T10:59:27Z

vector/src/main/res/layout/item_new_space.xml

+    android:background="@drawable/bg_space_item"
+    android:clickable="true"
+    android:focusable="true"
+    android:foreground="?attr/selectableItemBackground"


⚠️ Attribute android:foreground has no effect on API levels lower than 23 (current min is 21)

⚠️ Attribute android:foreground has no effect on API levels lower than 23 (current min is 21)

ElementBot · 2022-08-16T10:59:27Z

vector/src/main/res/layout/item_new_space_add.xml

+    android:background="@drawable/bg_space_item"
+    android:clickable="true"
+    android:focusable="true"
+    android:foreground="?attr/selectableItemBackground"


⚠️ Attribute android:foreground has no effect on API levels lower than 23 (current min is 21)

⚠️ Attribute android:foreground has no effect on API levels lower than 23 (current min is 21)

sonarqubecloud · 2022-08-16T12:08:51Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

8.4% Coverage
0.8% Duplication

ericdecanini added 12 commits August 2, 2022 17:44

Adds SpacesBottomSheet

ab4eda1

Merge remote-tracking branch 'origin/develop' into feature/eric/space…

55d8b6a

…-list-modal

Adds new space list controller

aa24deb

Fixes bug where bottom sheet sometimes renders with the wrong height

5d18365

Finalises home and add bottom sheet buttons

b4ed380

Makes bottom sheet dismiss on space change

79e6dd0

Makes space list work inside spaces

ff71e69

Fixes bottom sheet intermittently not having the correct height

0506c9a

Adds drag and drop to space list

a821f34

Appends to comment in SpaceListFragment and refactors SpaceListBottom…

90f2b93

…Sheet class name

Changes header text of bottom sheet to Change Space

0567fa3

Cleans up epoxy class for NewSpaceSummaryItem and adds ellipsize to h…

e6508e8

…eader

ericdecanini mentioned this pull request Aug 5, 2022

Space Switching: Bottom Sheet Doesn't Always Measure Properly #6750

Closed

ericdecanini requested review from fedrunov and amshakal August 5, 2022 15:08

ericdecanini changed the base branch from develop to feature/eric/new_fab August 5, 2022 15:09

ericdecanini added 3 commits August 5, 2022 17:10

Merge remote-tracking branch 'origin/develop' into feature/eric/space…

41d859d

…-list-modal # Conflicts: # vector/src/main/java/im/vector/app/features/home/NewHomeDetailFragment.kt

Merge remote-tracking branch 'origin/feature/eric/new_fab' into featu…

1ffa02c

…re/eric/space-list-modal # Conflicts: # vector/src/main/java/im/vector/app/features/home/room/list/home/HomeRoomListFragment.kt

Adds changelog file

7565707

ericdecanini marked this pull request as ready for review August 5, 2022 15:13

amshakal approved these changes Aug 5, 2022

View reviewed changes

ericdecanini added 3 commits August 9, 2022 10:52

Merge branch 'feature/eric/new_fab' into feature/eric/space-list-modal

7b61460

Fixes lint errors

9892c66

Fixes toMvRxBundle import

65b7a31

fedrunov suggested changes Aug 9, 2022

View reviewed changes

Merge branch 'feature/eric/new_fab' into feature/eric/space-list-modal

f94aad6

# Conflicts: # vector/src/main/res/layout/fragment_room_list.xml

Base automatically changed from feature/eric/new_fab to develop August 10, 2022 06:13

ericdecanini added 3 commits August 10, 2022 08:24

Removes params passed into HomeRoomListFragment and fixes lint error

ddaf539

Merge remote-tracking branch 'origin/develop' into feature/eric/space…

e87eefb

…-list-modal # Conflicts: # vector/src/main/java/im/vector/app/features/home/room/list/home/HomeRoomListFragment.kt

Fixes post merge errors

358ec5a

Changes changelog file extension

fd37b31

ericdecanini requested review from fedrunov and a team August 10, 2022 09:28

element-hq deleted a comment from ElementBot Aug 11, 2022

Merge remote-tracking branch 'origin/develop' into feature/eric/space…

8b0fba2

…-list-modal # Conflicts: # vector/src/main/java/im/vector/app/features/home/room/list/home/HomeRoomListFragment.kt

fedrunov approved these changes Aug 16, 2022

View reviewed changes

ElementBot reviewed Aug 16, 2022

View reviewed changes

ericdecanini merged commit 4fedafc into develop Aug 17, 2022

ericdecanini deleted the feature/eric/space-list-modal branch August 17, 2022 08:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds Space List Bottom Sheet #6749

Adds Space List Bottom Sheet #6749

ericdecanini commented Aug 5, 2022 •

edited

Loading

fedrunov left a comment

fedrunov Aug 9, 2022

ericdecanini Aug 10, 2022

fedrunov Aug 9, 2022

ericdecanini Aug 10, 2022 •

edited

Loading

fedrunov Aug 9, 2022

ericdecanini Aug 10, 2022

fedrunov Aug 9, 2022

fedrunov Aug 9, 2022

fedrunov left a comment

ElementBot Aug 16, 2022

ElementBot Aug 16, 2022

ElementBot Aug 16, 2022

ElementBot Aug 16, 2022

sonarqubecloud bot commented Aug 16, 2022

		@@ -0,0 +1 @@
		Adds space list bottom sheet for new app layout

Adds Space List Bottom Sheet #6749

Adds Space List Bottom Sheet #6749

Conversation

ericdecanini commented Aug 5, 2022 • edited Loading

Type of change

Content

Motivation and context

Screenshots / GIFs

Tests

Tested devices

Checklist

fedrunov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ericdecanini Aug 10, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fedrunov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Aug 16, 2022

ericdecanini commented Aug 5, 2022 •

edited

Loading

ericdecanini Aug 10, 2022 •

edited

Loading