Set PREFS_CRASH_KEY synchronously #5195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the app dies before this preference gets written to disk, and then the crash dialog is not displayed to the user Signed-off-by: Alex Baker <[email protected]>
ouchadam
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
makes a lot of sense to me since we're rethrowing a few lines later https://github.com/vector-im/element-android/blob/develop/vector/src/main/java/im/vector/app/features/rageshake/VectorUncaughtExceptionHandler.kt#L111 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the app dies before this preference gets written to disk, and
then the crash dialog is not displayed to the user
Signed-off-by: Alex Baker [email protected]
Pull Request Checklist