Merge pull request #5195 from abaker/fix_crash_detection

Set PREFS_CRASH_KEY synchronously
element-hq · Feb 10, 2022 · 56338c2 · 56338c2
2 parents f08b10b + a4b50d2
commit 56338c2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/5195.bugfix b/changelog.d/5195.bugfix
@@ -0,0 +1 @@
+Reliably display crash report prompt
diff --git a/vector/src/main/java/im/vector/app/features/rageshake/VectorUncaughtExceptionHandler.kt b/vector/src/main/java/im/vector/app/features/rageshake/VectorUncaughtExceptionHandler.kt
@@ -63,7 +63,7 @@ class VectorUncaughtExceptionHandler @Inject constructor(
      */
     override fun uncaughtException(thread: Thread, throwable: Throwable) {
         Timber.v("Uncaught exception: $throwable")
-        preferences.edit {
+        preferences.edit(commit = true) {
             putBoolean(PREFS_CRASH_KEY, true)
         }
         val b = StringBuilder()