Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate public space address length when user clicks away from #3934

Closed
kittykat opened this issue Sep 1, 2021 · 2 comments · Fixed by #4060
Closed

Validate public space address length when user clicks away from #3934

kittykat opened this issue Sep 1, 2021 · 2 comments · Fixed by #4060
Assignees
@BillCarsonFr
Labels
A-Spaces Spaces, groups, communities good first issue Good for newcomers O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Milestone
Sprint - Element ...

Comments

@kittykat
Copy link
Contributor

kittykat commented Sep 1, 2021 •
edited
Loading

Steps to reproduce

  1. Left menu -> "Add Space"
  2. "Public"
  3. Name -> thisisanamespacewithareallylongnamefornoreasonotherthantotesttheerrorthrownforrisiculouslylongnamespacesbecasuesoempeoplewilltrytonamethingsreallyobscurenamesbecausetheycanbefunsometimesbutapparentlyelementdoesntreallysupportthemorsoiwillfindoutsoooooooooooooooooooooooon
    -> Space address is auto-filled
  4. Click on "NEXT"

What did you expect?

Space address is validated for length

What happened?

Space address length is not validated until "CREATE SPACE" is clicked on the next screen

Screenshot_20210901-113952.png

Your phone model

n/a

Operating system version

n/a

Application version and app store

https://buildkite.com/organizations/matrix-dot-org/pipelines/element-android/builds/3224/jobs/a1fe572d-8a7b-4406-8a0f-37f4c9ff4787/artifacts/30990f61-8f7d-4dc6-af1e-340765110cc6

Homeserver

n/a

Have you submitted a rageshake?

No
@kittykat kittykat added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Spaces Spaces, groups, communities S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow good first issue Good for newcomers labels Sep 1, 2021
@BillCarsonFr BillCarsonFr self-assigned this Sep 16, 2021
@daniellekirkwood
Copy link
Contributor

Screenshot_20210901-105752_Element dbg
Screenshot_20210901-105817_Element dbg

@BillCarsonFr BillCarsonFr mentioned this issue Sep 22, 2021
Merged
@bmarty
Copy link
Member

bmarty commented Oct 4, 2021

in EA 1.3.2

@bmarty bmarty added this to the Sprint - Element 1.3.2 milestone Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BillCarsonFr BillCarsonFr

Labels
A-Spaces Spaces, groups, communities good first issue Good for newcomers O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
Sprint - Element 1.3.2
Development

Successfully merging a pull request may close this issue.

Client side validation of alias max length element-hq/element-android
4 participants
@kittykat @bmarty @BillCarsonFr @daniellekirkwood