Client side validation of alias max length #4060
Conversation
| @@ -94,6 +94,8 @@ class SpaceDetailEpoxyController @Inject constructor( | |||
| hint(host.stringProvider.getString(R.string.create_space_alias_hint)) | |||
| suffixText(":" + data.homeServerName) | |||
| prefixText("#") | |||
| // spaces alias are limited to 255 | |||
| maxLength(255) | |||
There was a problem hiding this comment.
how would you feel about a shared constant across all the usages?
something like const val MAX_SPACE_ALIAS_LENGTH = 255 could potentially allow us to replace the comment as well as the variable name would have the same information
There was a problem hiding this comment.
agreed, thanks, in a general rule, we avoid magic numbers.
Also, I do not see such limitation in the doc (https://matrix.org/docs/spec/client_server/r0.6.1#room-aliases).
There was a problem hiding this comment.
Ah the length limitation is defined here: https://matrix.org/docs/spec/appendices#room-aliases
Heads up that the limitation counts the sign # and the domain so a computation is needed here.
@BillCarsonFr if you add this link above the const you will defined, I would be super happy.
BillCarsonFr
added
the
Z-NextRelease
| @@ -165,6 +165,8 @@ object MatrixPatterns { | |||
| fun candidateAliasFromRoomName(name: String): String { | |||
| return Regex("\\s").replace(name.lowercase(), "_").let { | |||
| "[^a-z0-9._%#@=+-]".toRegex().replace(it, "") | |||
| }.let { alias -> | |||
| if (alias.length > 255) alias.substring(0, 255) else alias | |||
There was a problem hiding this comment.
I would simplify by always taking the substring here, no need to check the length.
There was a problem hiding this comment.
also deduce the domain length + 1 (for #)
bmarty
force-pushed
the
feature/bca/space_validate_alias
branch
from
f9afa4a to
7636b4d
Compare
| /** | ||
| * Max length for an alias. Room aliases MUST NOT exceed 255 bytes (including the # sigil and the domain). | ||
| * See [maxAliasLocalPartLength] | ||
| * Ref. https://matrix.org/docs/spec/appendices#room-aliases |
|
Updated:
|
| fun candidateAliasFromRoomName(roomName: String, domain: String): String { | ||
| return roomName.lowercase() | ||
| // Replace spaces by '_' | ||
| .let { Regex("\\s").replace(it, "_") } |
There was a problem hiding this comment.
nit: these comments could be replaced by extensions with the same name as the comment (and potentially be reused)
roomName
.lowercase()
.replaceSpacesWithUnderscore()
.removeInvalidRoomNameChars()
.limitLength(length = MatrixConstants.maxAliasLocalPartLength(domain))
fun String.replaceSpacesWithUnderscore() = Regex("\\s").replace(this, "_")
fun String.removeInvalidRoomNameChars() = "[^a-z0-9._%#@=+-]".toRegex().replace(this, "")
fun String.limitLength(length: Int) = this.substring(0, length)I'm more in the self documenting code camp than adding comments to describe what the code does, where possible!
Fixes #3934
Adding client side limitation on room alias length
Just a maxlength on input with a counter