fix: deep linking for veworld extension (#195)

* fix: deep linking for veworld extension * fix: tests * chore: increase version
vechain · Feb 12, 2024 · 2f7cfd0 · 2f7cfd0
1 parent a34b536
commit 2f7cfd0
Show file tree

Hide file tree

Showing 9 changed files with 16 additions and 29 deletions.
diff --git a/packages/dapp-kit-react/package.json b/packages/dapp-kit-react/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@vechain/dapp-kit-react",
-    "version": "1.0.6",
+    "version": "1.0.7",
     "private": false,
     "homepage": "https://github.com/vechainfoundation/vechain-dapp-kit",
     "repository": "github:vechain/vechain-dapp-kit",

diff --git a/packages/dapp-kit-ui/package.json b/packages/dapp-kit-ui/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@vechain/dapp-kit-ui",
-    "version": "1.0.6",
+    "version": "1.0.7",
     "private": false,
     "description": "Vanilla JS DAppKit",
     "keywords": [

diff --git a/packages/dapp-kit-ui/src/components/modals/connect-modal/connect-modal.ts b/packages/dapp-kit-ui/src/components/modals/connect-modal/connect-modal.ts
@@ -9,6 +9,7 @@ import {
     defaultI18n,
     Font,
     WalletSources,
+    VEWORLD_WEBSITE,
 } from '../../../constants';
 import {
     DarkChevronLeftSvg,
@@ -97,6 +98,14 @@ export class ConnectModal extends LitElement {
     @property({ type: Function })
     onSourceClick = (source?: SourceInfo): void => {
         if (source) {
+            if (source.id === 'veworld' && !window.vechain) {
+                const path = `${location.host}${location.pathname}${location.search}`;
+                window.open(
+                    `${VEWORLD_WEBSITE}/?discoveryUrl=${path}`,
+                    '_self',
+                );
+                return;
+            }
             if (source.id !== 'wallet-connect') {
                 this.setWaitingForTheSignature(true);
                 this.requestForConnectionCertificate = true;

diff --git a/packages/dapp-kit-ui/src/constants/index.ts b/packages/dapp-kit-ui/src/constants/index.ts
@@ -6,3 +6,4 @@ export * from './stores';
 export * from './font';
 export * from './i18n';
 export * from './z-index';
+export * from './veworld';
diff --git a/packages/dapp-kit-ui/src/constants/veworld.ts b/packages/dapp-kit-ui/src/constants/veworld.ts
@@ -0,0 +1 @@
+export const VEWORLD_WEBSITE = 'https://veworld.com';
diff --git a/packages/dapp-kit/package.json b/packages/dapp-kit/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@vechain/dapp-kit",
-    "version": "1.0.6",
+    "version": "1.0.7",
     "private": false,
     "homepage": "https://github.com/vechainfoundation/vechain-dapp-kit",
     "repository": "github:vechain/vechain-dapp-kit",

diff --git a/packages/dapp-kit/src/classes/wallet-manager.ts b/packages/dapp-kit/src/classes/wallet-manager.ts
@@ -275,9 +275,7 @@ class WalletManager {
     private getAvailableSources = (): WalletSource[] => {
         const wallets: WalletSource[] = [];
 
-        if (window.vechain) {
-            wallets.push('veworld');
-        }
+        wallets.push('veworld');
 
         if (this.options.walletConnectOptions) {
             wallets.push('wallet-connect');

diff --git a/packages/dapp-kit/test/wallet-tests/sync.test.ts b/packages/dapp-kit/test/wallet-tests/sync.test.ts
@@ -82,7 +82,7 @@ describe('sync', () => {
             );
         });
 
-        it('get available sources - should not include veworld', () => {
+        it('get available sources - should not include sync', () => {
             const connex = createUnitTestConnex();
 
             const sources = connex.wallet.state.availableSources;

diff --git a/packages/dapp-kit/test/wallet-tests/veworld-extension.test.ts b/packages/dapp-kit/test/wallet-tests/veworld-extension.test.ts
@@ -40,26 +40,4 @@ describe('veworld', () => {
             expect(sources).toContain('veworld');
         });
     });
-
-    describe('is NOT in veworld browser', () => {
-        beforeEach(() => {
-            window.vechain = undefined;
-        });
-
-        it('not installed - should throw error', () => {
-            const connex = createUnitTestConnex();
-
-            expect(() => connex.wallet.setSource('veworld')).toThrowError(
-                'VeWorld Extension is not installed',
-            );
-        });
-
-        it('get available sources - should not include veworld', () => {
-            const connex = createUnitTestConnex();
-
-            const sources = connex.wallet.state.availableSources;
-
-            expect(sources).not.toContain('veworld');
-        });
-    });
 });
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		export const VEWORLD_WEBSITE = 'https://veworld.com';