Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use getBooleanInput for update-comment argument #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use getBooleanInput for update-comment argument #25

wants to merge 2 commits into from

Conversation

alexjfno1
Copy link
Contributor

Fixes #21

The getInput function only returns string values - actions/toolkit#361 which means when checking the update-comment input value returns "false" which evaluates to be true. This fix uses the new getBooleanInput - actions/toolkit#725

@alexjfno1 alexjfno1 marked this pull request as ready for review October 6, 2021 09:54
@alexjfno1
Copy link
Contributor Author

@vebr this is ready for review when you have some time 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comment is updated even with option in false
1 participant
@alexjfno1