Addressed some of my points #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Easier to change
0 is a valid pin and should NOT be used as a no-pin
Inline methods must be defined in .h in order to work
Double is overkill
getClosestValidMilliVolt() wasn't part of QC3Control as it's suppost to be :)
added getVoltageFloat() to return the voltage as a float instead of an byte.
|
Ow, I have to say I didn't rerun the doc to check it... 😳 |
|
Still a pity it's never pulled 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I addressed most of my points in #4 .
I have to say, I don't have a QC3 charger at the moment (ordered one) so all changes are made "dry" and need to be checked.
Biggest point of mine still open, the setVoltage() part. Is it really necessary to wait 60ms in discrete mode?
First, I find it a bit long for a(n ugly) delay.
Second, wouldn't it be nicer if a set voltage went via the closest (but lower) discrete step? Or make it optional? That way you can jump from 3,6V to 12V quick. Or even from 3,6V to 15V quick by first going to the discrete 12V step.
I think I'll edit this next week (but I don't know how much free time I'll have on my hands).
Another point I'll like to look at is the legacy mode. I think it's a nice feature but it adds some overhead now. Might be nicer to overload QC3Control to a QC3LegacyControl class.
Right, that's all for now 😃