Skip to content

Commit

Permalink
fix(fsx): no validation error when hour property set to 24 in the `…
Browse files Browse the repository at this point in the history
…LustreMaintenanceTime` class. (aws#30342)

### Issue # (if applicable)

Closes aws#30341 

### Reason for this change
The `hour` property in the `LustreMaintenanceTime` class should be between 0 and 23.

But no validation error occurs when it is set to 24.



### Description of changes
In the validate method, I changed it so that an error is thrown when the hour is greater than 23, instead of when the hour is greater than 24. 

This allows a validation error to occur when the hour is set to 24.



### Description of how you validated changes
Changed unit tests and add integ tests.


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
mazyu36 authored and Dahlberg Victor committed Jun 10, 2024
1 parent affe6cf commit 163c56d
Show file tree
Hide file tree
Showing 11 changed files with 1,732 additions and 9 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 163c56d

Please sign in to comment.