Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: module hot reload #755

Merged
merged 12 commits into from
Nov 8, 2022
Prev Previous commit
Next Next commit
fix(hot-reloading): moved some stuff around so that the inputs are lo…
…aded correctly
TimPietrusky committed Nov 1, 2022
commit 06e884b16c28f5cdb14296ada9b67983877c3ec2
4 changes: 2 additions & 2 deletions src/application/worker/index.worker.js
Original file line number Diff line number Diff line change
@@ -329,12 +329,12 @@ async function start() {
}

store.commit("groups/SWAP", {});
store.commit("modules/SWAP", {});
store.commit("inputs/SWAP", {});
store.commit("modules/SWAP", {});

store.commit("groups/CLEAR_SWAP", {});
store.commit("modules/CLEAR_SWAP", {});
store.commit("inputs/CLEAR_SWAP", {});
store.commit("modules/CLEAR_SWAP", {});

return;
}
14 changes: 4 additions & 10 deletions src/application/worker/store/modules/modules.js
Original file line number Diff line number Diff line change
@@ -53,7 +53,7 @@ async function initialiseModuleProperties(
if (useExistingData) {
for (let j = 0, len = propKeys.length; j < len; j += 1) {
const prop = propKeys[j];
const propDidExist = !!module.$props[prop];
const propDidExist = !!existingData.$props[prop];

if (propDidExist) {
module.$props[prop].id = existingData.$props[prop].id;
@@ -75,8 +75,6 @@ async function initialiseModuleProperties(
useExistingData
);

console.log(propsWithoutId);

if (
(!isGallery && !useExistingData) ||
(propsWithoutId.length && propsWithoutId.indexOf(propKey) > -1)
@@ -263,12 +261,7 @@ const actions = {
module.$moduleName = moduleName;
module.props = {};

await initialiseModuleProperties(
props,
module,
moduleMeta.isGallery,
!!existingModule
);
await initialiseModuleProperties(props, module, moduleMeta.isGallery);

const dataKeys = Object.keys(data);
module.data = {};
@@ -343,7 +336,8 @@ const actions = {
props,
module,
moduleMeta.isGallery,
true
true,
existingModule
);
}