feat(renderer): adds three.js renderer #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks super clean and is very simple, thank you very much! The cube is only showing, when something else is visible in the background. I guess this is a bug? |
|
@TimPietrusky no, that's intended - I've updated the sample module to include a toggle to use the canvas as material map or not. Previously, if there was nothing on the canvas, the map is entirely transparent so nothing would be output. |
|
Works perfectly, thank you both! |
2xAA
pushed a commit
that referenced
this pull request
Mar 10, 2022
# [3.21.0](3.20.2...3.21.0) (2022-03-10) ### Bug Fixes * **image:** fixes texture initialisation ([#707](#707)) ([b09ee89](b09ee89)), closes [#706](#706) ### Features * **help:** adds link to github discussions in help menu ([#679](#679)) ([c6c24bf](c6c24bf)) * **renderer:** adds three.js renderer ([#684](#684)) ([34b4826](34b4826))
|
🎉 This PR is included in version 3.21.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't use the latest version of three as it has some bugs with CubeCameras, from my recent work with three.js.
We can update later down the road.