Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auto-update): adds github releases electron-builder config #419

Merged
merged 6 commits into from
Sep 13, 2020

Conversation

2xAA
Copy link
Member

@2xAA 2xAA commented Sep 8, 2020

Adds required GitHub config options to electron-builder for auto-updater and GitHub releases.

re #371

@2xAA 2xAA added the enhancement Feature requests label Sep 8, 2020
@2xAA 2xAA requested a review from TimPietrusky September 8, 2020 21:47
@TimPietrusky
Copy link
Member

@2xAA does this mean that Travis will no longer publish the binaries to GitHub, but electron-builder will do this?

Copy link
Member

@TimPietrusky TimPietrusky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@2xAA
Copy link
Member Author

2xAA commented Sep 9, 2020

@2xAA does this mean that Travis will no longer publish the binaries to GitHub, but electron-builder will do this?

Upon reading the docs again, yes I think electron-builder does this.

We would remove the Travis publish step.

@2xAA 2xAA merged commit 64177cf into main Sep 13, 2020
@2xAA 2xAA deleted the feat/auto-updater branch September 13, 2020 14:22
@2xAA 2xAA added released and removed released labels Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants