Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: removes package-lock.json #417

Merged
merged 1 commit into from
Sep 8, 2020
Merged

chore: removes package-lock.json #417

merged 1 commit into from
Sep 8, 2020

Conversation

2xAA
Copy link
Member

@2xAA 2xAA commented Sep 6, 2020

No description provided.

@2xAA 2xAA requested a review from TimPietrusky September 6, 2020 21:44
@2xAA 2xAA merged commit 3f9ef92 into main Sep 8, 2020
@2xAA 2xAA deleted the chore/packagelock branch September 8, 2020 12:19
@TimPietrusky
Copy link
Member

TimPietrusky commented Sep 9, 2020 •
edited
Loading

@2xAA why did you do this? I mean getting rid of the package-lock.json

@2xAA
Copy link
Member Author

2xAA commented Sep 9, 2020

We use yarn which has it's own lock file.

That lockfile was committed recently from an npm install and did not exist in the project previously.

@2xAA 2xAA added released and removed released labels Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimPietrusky TimPietrusky Awaiting requested review from TimPietrusky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2xAA @TimPietrusky