Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set EP_GH_IGNORE_TIME to true for GitHub-Action #602

Closed
TimPietrusky opened this issue Jun 30, 2021 · 1 comment · Fixed by #652
Closed

Set EP_GH_IGNORE_TIME to true for GitHub-Action #602

TimPietrusky opened this issue Jun 30, 2021 · 1 comment · Fixed by #652
Labels
ci-build Issues pertaining to the continuous integration build enhancement Feature requests released

Comments

@TimPietrusky
Copy link
Member

In order to create a release even after 2 hours, we should set this value to true in our workflows, otherwise it's not possible to create a release after 2 hours. This is a limitation of https://github.com/electron-userland/electron-builder/blob/master/packages/electron-publish/src/gitHubPublisher.ts#L115
@TimPietrusky TimPietrusky added ci-build Issues pertaining to the continuous integration build enhancement Feature requests labels Jun 30, 2021
TimPietrusky added a commit that referenced this issue Nov 10, 2021
@TimPietrusky
fix(build): ignore the time so that we can always do a release even a…
d46cb9e 
…fter 2 hours

fixes #602
@TimPietrusky TimPietrusky mentioned this issue Nov 10, 2021
Merged
@2xAA 2xAA closed this as completed in #652 Nov 10, 2021
2xAA pushed a commit that referenced this issue Nov 10, 2021
@TimPietrusky
fix(build): ignore the time so that we can always do a release even a…
58da409 
…fter 2 hours (#652)

fixes #602
2xAA pushed a commit that referenced this issue Nov 10, 2021
@semantic-release-bot
chore(release): 3.19.1
6c35693 
## [3.19.1](3.19.0...3.19.1) (2021-11-10)

### Bug Fixes

* **build:** ignore the time so that we can always do a release even after 2 hours ([#652](#652)) ([58da409](58da409)), closes [#602](#602)
* **release:** use node 14 ([7b3f169](7b3f169))
@2xAA
Copy link
Member

2xAA commented Nov 10, 2021

🎉 This issue has been resolved in version 3.19.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@2xAA 2xAA added the released label Nov 10, 2021
2xAA pushed a commit that referenced this issue Jan 7, 2022
@semantic-release-bot @2xAA
chore(release): 3.19.1
5305741 
## [3.19.1](3.19.0...3.19.1) (2021-11-10)

### Bug Fixes

* **build:** ignore the time so that we can always do a release even after 2 hours ([#652](#652)) ([58da409](58da409)), closes [#602](#602)
* **release:** use node 14 ([7b3f169](7b3f169))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci-build Issues pertaining to the continuous integration build enhancement Feature requests released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(build): ignore the time so that we can always do a release even after 2 hours vcync/modV
2 participants
@TimPietrusky @2xAA