Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Audio Feature]: min / max value #453

Closed
TimPietrusky opened this issue Nov 10, 2020 · 1 comment · Fixed by #468
Closed

[Audio Feature]: min / max value #453

TimPietrusky opened this issue Nov 10, 2020 · 1 comment · Fixed by #468
Labels
enhancement Feature requests released

Comments

@TimPietrusky
Copy link
Member

Is your feature request related to a problem? Please describe.
I'm frustrated that the min / max that already exists for a module property is not used when attaching an audio feature to that property.

Describe the solution you'd like
Either add another min / max input to the audio feature or use the min / max value also as a range for the property value including the changes from the audio feature.

Describe alternatives you've considered
In modV 2 we could use expressions, but in modV 3 there is no possibility to limit the changes an audio feature has on a property.

Additional context
Party related to #415
@TimPietrusky TimPietrusky added the enhancement Feature requests label Nov 10, 2020
@2xAA 2xAA mentioned this issue Nov 11, 2020
Closed
2xAA added a commit that referenced this issue Nov 28, 2020
@2xAA
feat(expression): adds expressions
d781a8a 
Adds the expression editor from modV 2

fix #453 fix #415
@2xAA 2xAA mentioned this issue Nov 28, 2020
Merged
@2xAA 2xAA closed this as completed in #468 Dec 1, 2020
2xAA added a commit that referenced this issue Dec 1, 2020
@2xAA @TimPietrusky
feat(expression): adds expressions (#468)
ab13872 
* feat(expression): adds expressions

Adds the expression editor from modV 2

fix #453 fix #415

* feat(expressions): adds time variable to scope

* feat(expressions): adds preset save/restore to expressions state

* feat(expressions): Make textarea fill up the whole space

* revert(expression): reduces textarea size to align with tween textarea

Co-authored-by: Tim Pietrusky <[email protected]>
2xAA pushed a commit that referenced this issue Dec 1, 2020
@semantic-release-bot
chore(release): 3.5.0
9d2c397 
# [3.5.0](3.4.0...3.5.0) (2020-12-01)

### Features

* **expression:** adds expressions ([#468](#468)) ([ab13872](ab13872)), closes [#453](#453) [#415](#415)
@2xAA
Copy link
Member

2xAA commented Dec 1, 2020

🎉 This issue has been resolved in version 3.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@2xAA 2xAA added the released label Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature requests released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(expression): adds expressions vcync/modV
2 participants
@TimPietrusky @2xAA