Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error while building modV on Windows 10 #167

Closed
TimPietrusky opened this issue Jun 23, 2018 · 8 comments
Closed

Error while building modV on Windows 10 #167

TimPietrusky opened this issue Jun 23, 2018 · 8 comments
Assignees
@2xAA
Labels
bug Something isn't working documentation Improvements or additions to documentation windows Issues relating to Microsoft Windows

Comments

@TimPietrusky
Copy link
Member

TimPietrusky commented Jun 23, 2018 •
edited
Loading

When installing modV by using yarn or npm install on Windows 10 I was receiving the following error because of node-sass:

MSBUILD : error MSB3428: Could not load the Visual C++ component "VCBuild.exe"

This can be solved by installing the windows-build-tools like this in a terminal with Admin-rights:

npm install --global --production windows-build-tools

This should be mentioned somewhere so that people on Windows don't run into the same problem.
@TimPietrusky
Copy link
Member Author

If you have all of that above and it’s still failing because node-gyp can’t find some libsass src files: Your node Version might be too high for node-sass.

In my case I was using node 10. The fix was to use node-sass latest, but that is just a quick fix.

@2xAA
Copy link
Member

2xAA commented Jun 23, 2018

modV need some serious work on its documentation. Sorry about this.
Will add asap!

@TimPietrusky
Copy link
Member Author

TimPietrusky commented Jun 25, 2018 •
edited
Loading

It’s totally fine, I’m just adding everything I can to address this problem so we can fix it for other people!

@2xAA 2xAA mentioned this issue Jun 25, 2018
Merged
@2xAA 2xAA added bug Something isn't working documentation Improvements or additions to documentation labels Jul 5, 2018
@2xAA 2xAA added the windows Issues relating to Microsoft Windows label Sep 12, 2018
@TimPietrusky
Copy link
Member Author

The problem is still there in modV 2.0. The version of node-sass is still outdated.

@2xAA
Copy link
Member

2xAA commented Oct 10, 2018

Would you mind creating a PR to fix this if you already found a fix?

@TimPietrusky
Copy link
Member Author

Yes!

@TimPietrusky TimPietrusky self-assigned this Oct 10, 2018
@TimPietrusky
Copy link
Member Author

TimPietrusky commented Oct 10, 2018 •
edited
Loading

@2xAA How should we handle the documentation part of this issue?

Anything else?

Sorry, something went wrong.

TimPietrusky added a commit that referenced this issue Oct 21, 2018
@TimPietrusky
build(windows-build-tools): Added dependency for Windows 10

Verified

This commit was signed with the committer’s verified signature.
snyk-bot Snyk bot
GPG key ID: 78AC5AE55A47A65B
Verified
Learn about vigilant mode
12dd7bb 
The windows-build-tools are required in order to run modV

Fixes #167
@TimPietrusky TimPietrusky assigned 2xAA and unassigned TimPietrusky Oct 21, 2018
@2xAA
Copy link
Member

2xAA commented Oct 22, 2018

@TimPietrusky You should add this to the documentation feature branch: #268

@2xAA 2xAA closed this as completed in fa46dc6 Oct 28, 2018
2xAA added a commit that referenced this issue Jul 24, 2020
@2xAA
feat(panel-position): adds saving panel positions to local storage (#167
78b6752 
)

* feat(panel-position): adds saving panel positions to local storage

Upgrades vue-golden-layout so we can use Golden Layout componentState to track panels we need to
remove from Golden Layout state when saving.

fixes #131

* fix: removes unused variable

* docs(app.vue): adds jsdoc for new methods

* docs(app.vue): remove extraneous comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@2xAA 2xAA

Labels
bug Something isn't working documentation Improvements or additions to documentation windows Issues relating to Microsoft Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TimPietrusky @2xAA