Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

Add fake identity for VCSs #104

Merged
merged 8 commits into from
Jul 25, 2017
Merged

Add fake identity for VCSs #104

merged 8 commits into from
Jul 25, 2017

Conversation

jspricke
Copy link
Contributor

This makes the unit tests self contained.

jspricke and others added 2 commits July 18, 2017 18:24
@wjwwood
Copy link
Contributor

wjwwood commented Jul 18, 2017

I updated the travis settings to only test current versions of Python which should fix the setup issues in CI, but several of the matrix entries just have failing tests.

@jspricke
Copy link
Contributor Author

Looks like your update hid the test output and made Travis green :). For comparison, this is the corresponding Debian build log with the change and test output: https://buildd.debian.org/status/fetch.php?pkg=ros-wstool&arch=all&ver=0.1.13-3&stamp=1500371291&raw=0. It's running python3.6 -m unittest discover -v, maybe we should do that as well?

@wjwwood
Copy link
Contributor

wjwwood commented Jul 24, 2017

Looks like your update hid the test output and made Travis green :).

Good catch, it looks like coverage is not installed for some reason. It's really bad behavior that it shows all tests passing because it couldn't import coverage.

It's running python3.6 -m unittest discover -v, maybe we should do that as well?

I don't think we need to do that. nosetest should work as it was before.

@wjwwood
Copy link
Contributor

wjwwood commented Jul 24, 2017

Hmm, it seems like python setup.py nosetest is not working correctly... it might be a setting in the setup.py that is affecting this. I'll have to debug it some more. Maybe I'll switch to the unittest invocation that @jspricke suggested, but I wanted to keep nosetest in case it was using some nosetest specific API in the tests (I didn't check for this yet).

@vcstools vcstools deleted a comment from coveralls Jul 24, 2017
@wjwwood
Copy link
Contributor

wjwwood commented Jul 24, 2017

Ok, sorry, I got the tests running again (the test layout was confusing nosetest). I couldn't use your suggested invocation @jspricke because it doesn't do the coverage stuff I think.

Now that the tests are running again, it is failing with the no author issue. Can you have another look?

@coveralls
Copy link

coveralls commented Jul 25, 2017

Coverage Status

Coverage remained the same at 81.992% when pulling 80d9026 on jspricke:fix_identity into c793ad8 on vcstools:master.

@jspricke
Copy link
Contributor Author

@wjwwood thanks for fixing Travis. This should be fine now.

@wjwwood
Copy link
Contributor

wjwwood commented Jul 25, 2017

@jspricke thank you for iterating on it!

@wjwwood wjwwood merged commit a8dcef1 into vcstools:master Jul 25, 2017
@jspricke jspricke deleted the fix_identity branch July 25, 2017 09:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants