review comments

Signed-off-by: Elazar Gershuni <[email protected]>

src/crab/cfg.hpp

@@ -365,10 +365,10 @@ class cfg_t final {
     }
 
     //! return a begin iterator of label_t's
-    const_label_iterator label_begin() { return boost::make_transform_iterator(m_blocks.begin(), get_label()); }
+    const_label_iterator label_begin() const { return boost::make_transform_iterator(m_blocks.begin(), get_label()); }
 
     //! return an end iterator of label_t's
-    const_label_iterator label_end() { return boost::make_transform_iterator(m_blocks.end(), get_label()); }
+    const_label_iterator label_end() const { return boost::make_transform_iterator(m_blocks.end(), get_label()); }
 
     //! return a begin iterator of label_t's
     [[nodiscard]]

src/main/check.cpp

@@ -66,7 +66,7 @@ static std::optional<raw_program> find_program(vector<raw_program>& raw_progs, c
     return {};
 }
 
-int main(const int argc, char** argv) {
+int main(int argc, char** argv) {
     // Always call ebpf_verifier_clear_thread_local_state on scope exit.
     at_scope_exit<ebpf_verifier_clear_thread_local_state> clear_thread_local_state;
 

src/main/run_yaml.cpp

@@ -8,7 +8,7 @@
 // Avoid affecting other headers by macros.
 #include "CLI11/CLI11.hpp"
 
-int main(const int argc, char** argv) {
+int main(int argc, char** argv) {
     CLI::App app{"Run YAML test cases"};
 
     std::string filename;

src/test/conformance_check.cpp

@@ -45,7 +45,7 @@ std::vector<std::byte> base16_decode(const std::string& input) {
  * the first argument. It then executes the BPF program and prints the
  * value of r0 at the end of execution.
  */
-int main(const int argc, char** argv) {
+int main(int argc, char** argv) {
     CLI::App app{"Check conformance"};
     bool debug = false;
     app.add_flag("--debug", debug, "Debug");