Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't close socket on Lwt.Canceled. #129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't close socket on Lwt.Canceled. #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lwt/websocket_lwt_unix.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,9 @@ let connect ?(extra_headers = Cohttp.Header.init ())
>|= fun (ic, oc) ->
let read_frame = make_read_frame ?buf ~mode:(Client random_string) ic oc in
let read_frame () =
Lwt.catch read_frame (fun exn ->
Lwt.catch read_frame (function
| Lwt.Canceled as exn -> Lwt.fail exn
| exn ->
Lwt.async (fun () -> Lwt_io.close ic) ;
Lwt.fail exn ) in
let buf = Buffer.create 128 in
Expand Down