Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filtering undefined values in array of SelectField (fixes #691). #695

Merged
merged 2 commits into from
Mar 25, 2020

Conversation

kestarumper
Copy link
Member

This PR introduces filtering undefined values inside SelectField to fix empty boxes.

@kestarumper kestarumper requested a review from radekmie as a code owner March 23, 2020 09:38
@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #695 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #695   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files         163      163           
  Lines        1810     1812    +2     
  Branches      562      563    +1     
=======================================
+ Hits         1780     1782    +2     
  Misses         10       10           
  Partials       20       20           
Impacted Files Coverage Δ
packages/uniforms-antd/src/SelectField.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 381541f...522438c. Read the comment docs.

@kestarumper kestarumper linked an issue Mar 23, 2020 that may be closed by this pull request
@kestarumper kestarumper added the Type: Bug Bug reports and their fixes label Mar 23, 2020
@radekmie radekmie merged commit 71f8e87 into master Mar 25, 2020
@radekmie radekmie deleted the empty-select-boxes-antd branch March 25, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug reports and their fixes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

SimpleSchema: minCount arrays with options set empty checkboxes
2 participants