Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register minCount and maxCount in filterDOMProps of JSONSchema #1061

Merged
merged 3 commits into from
Nov 3, 2021

Conversation

kestarumper
Copy link
Member

This PR closes #981 by registering minCount and maxCount in filterDOMProps when JSONSchemaBridge is imported.

@kestarumper kestarumper self-assigned this Oct 27, 2021
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #1061 (fe141e5) into master (36b3671) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1061   +/-   ##
=======================================
  Coverage   98.59%   98.60%           
=======================================
  Files         202      203    +1     
  Lines        3211     3217    +6     
  Branches      829      829           
=======================================
+ Hits         3166     3172    +6     
  Partials       45       45           
Impacted Files Coverage Δ
packages/uniforms-bridge-json-schema/src/index.ts 100.00% <100.00%> (ø)
...ckages/uniforms-bridge-json-schema/src/register.ts 100.00% <100.00%> (ø)
packages/uniforms/src/AutoForm.tsx 100.00% <0.00%> (ø)
packages/uniforms/src/BaseForm.tsx 100.00% <0.00%> (ø)
packages/uniforms/src/useField.tsx 100.00% <0.00%> (ø)
packages/uniforms/src/QuickForm.tsx 100.00% <0.00%> (ø)
packages/uniforms/src/ValidatedForm.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36b3671...fe141e5. Read the comment docs.

@kestarumper kestarumper marked this pull request as ready for review October 27, 2021 16:04
@kestarumper kestarumper changed the title Register minCount and maxCount in filterDOMProps of JSONSchema Register minCount and maxCount in filterDOMProps of JSONSchema Oct 27, 2021
@kestarumper kestarumper requested a review from radekmie October 30, 2021 05:22
@radekmie radekmie merged commit 55b4169 into master Nov 3, 2021
@radekmie radekmie deleted the fix/981 branch November 3, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

json-schema minItems maxItems throws React warnings about minCount/maxCount
3 participants