Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly typed props in TextField from uniforms-material #987

Closed
Florian3k opened this issue Jul 27, 2021 · 2 comments · Fixed by #988
Closed

Incorrectly typed props in TextField from uniforms-material #987

Florian3k opened this issue Jul 27, 2021 · 2 comments · Fixed by #988
Assignees
Labels
Type: Bug Bug reports and their fixes
Milestone

Comments

@Florian3k
Copy link

Florian3k commented Jul 27, 2021

TextField component props inside uniforms-material are typed using StandardTextFieldProps from @material-ui/core/TextField
Inside material-ui, TextField's props are typed using
type TextFieldProps = StandardTextFieldProps | FilledTextFieldProps | OutlinedTextFieldProps;
This results in some props being typed incorrectly, for example variant prop has type "standard" | undefined, while it should be "standard" | "filled" | "outlined" | undefined

Using uniforms-material 3.5.1

@Florian3k Florian3k changed the title Missing/incorrectly typed props in TextField from uniforms-material Incorrectly typed props in TextField from uniforms-material Jul 27, 2021
@wadamek65
Copy link
Contributor

@radekmie Do you maybe know if this was typed like this on purpose or is it simply an oversight? If it's an oversight I'll take over the issue and submit a PR.

@wadamek65 wadamek65 added the Type: Bug Bug reports and their fixes label Jul 27, 2021
@wadamek65 wadamek65 self-assigned this Jul 27, 2021
@radekmie radekmie added this to the v3.5 milestone Jul 30, 2021
@radekmie
Copy link
Contributor

Yep, @wadamek65 is 100% right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug reports and their fixes
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants