Using the error prop causes console errors on validations

[idmadj]

When using the error prop with a ValidatedForm, ValidatedQuickForm and AutoForm, an uncaught promise error is logged to the console whenever the model is validated after a submit (such as when manipulating model data).

Demo: https://codesandbox.io/s/lx4rz1001q

The problem seems to lie in ValidatedForm.onValidateModel. Whenever the error prop is set or schema validation throws, it inevitably leads the returned promise to reject , and both calls to this.onValidate() and this.onValidateModel() in componentWillReceiveProps are unhandled, causing the console error.

componentWillReceiveProps ({model, schema, validate, validator}) {
    super.componentWillReceiveProps(...arguments);

    if (this.props.schema !== schema || this.props.validator !== validator) {
        this.setState(({bridge}) => ({
            validator: bridge.getValidator(validator)
        }), () => {
            if (validate === 'onChange' || validate === 'onChangeAfterSubmit' && this.state.validate) {
                this.onValidate();
            }
        });
    } else if (!isEqual(this.props.model, model)) {
        if (validate === 'onChange' || validate === 'onChangeAfterSubmit' && this.state.validate) {
            this.onValidateModel(model);
        }
    }
}

onValidateModel (model) {
    model = this.getModel('validate', model);

    let catched = this.props.error || null;
    try {
        this.state.validator(model);
    } catch (error) {
        catched = error;
    }

    return new Promise((resolve, reject) => {
        this.props.onValidate(model, catched, (error = catched) => {
            // Do not copy error from props to state.
            this.setState(() => ({error: error === this.props.error ? null : error}), () => {
                if (error) {
                    reject(error);
                } else {
                    resolve();
                }
            });
        });
    });
}

[radekmie]

Hi @idmadj - good catch! Well, indeed, componentWillReceiveProps is not handling it at all. Maybe it's a good idea to silent it, just like in #onSubmit. Maybe you'd like to submit a PR for it?

[idmadj]

Hey @radekmie, sure thing! Silencing seems like the way to go. Just submitted PR #472.