uniforms-bootstrap4 errorsfield not red

[ggerber]

I notice that the errorsfield is red when using uniforms-antd in the demo, but not when using uniforms-bootstrap4. Is it standard styling for bootrap4 to not use a color? Without a background color of sorts the errorsfield blends in with the rest of the form making it less intuitive to see that it is actually a list of validation errors.

[radekmie]

I think it should be red - inputs borders are. Maybe you'd like to submit a PR with it? I'm not an expert in bootstrap though (nor 3 or 4) so let's ask @zeroasterisk.

[zeroasterisk]

Error state for Bootstrap 4 is basically just: form-group has-danger
http://v4-alpha.getbootstrap.com/components/forms/#validation

Which is being set here:

uniforms/packages/uniforms-bootstrap4/src/wrapField.js

Line 47 in a8e026e

'has-danger': error,

@radekmie this looks correct to me...

I have tested it on my local project using:

    "bootstrap": "^4.0.0-alpha.6",
    "uniforms": "^1.18.1",
    "uniforms-bootstrap4": "^1.18.1",

[radekmie]

@zeroasterisk yep, it's working in the wrapField - this issue is concerned on <ErrorsField />.

[zeroasterisk]

oh... hmmm... ok - I can make a PR which would "style" the <ErrorsField /> if you like.

I'd probably do it as an outline card:
http://v4-alpha.getbootstrap.com/components/card/#outline-cards

Is that too opinionated, or ok?

[radekmie]

@ggerber what do you think? I'm OK with both.

[ggerber]

Hi Radoslow, I am a novice ito UI's. But my opinion: Cardlayout with red boder and black normal text is too vague. Cardlayout with red background could be too loud for some people Cardlayout with red border and red bold text may be a good compromise. Kind regards

…

On 28 June 2017 at 08:23, Radosław Miernik ***@***.***> wrote: @ggerber <https://github.com/ggerber> what do you think? I'm OK with both. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#301 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKC35kMYddshp2oRZpZQCvIVDe9G4Z_Qks5sIfF9gaJpZM4OBzFv> .