Improved onChange type.

vazco · Feb 26, 2021 · 63e4bac · 63e4bac
1 parent 94d48fc
commit 63e4bac
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/packages/uniforms/src/types.ts b/packages/uniforms/src/types.ts
@@ -50,13 +50,18 @@ export type GuaranteedProps<Value> = {
   id: string;
   label: ReactNode;
   name: string;
-  onChange: (value: any, name?: string) => void;
+  onChange: OnChange<Value | undefined>;
   placeholder: string;
   readOnly: boolean;
   showInlineError: boolean;
   value?: Value;
 };
 
+type OnChange<Value> = {
+  (value: Value): void;
+  (value: any, name: string): void;
+};
+
 export type HTMLFieldProps<Value, Element, Extension = object> = FieldProps<
   Value,
   HTMLProps<Element>,

diff --git a/website/pages-parts/CustomFields/CycleField.tsx b/website/pages-parts/CustomFields/CycleField.tsx
@@ -33,7 +33,7 @@ function Cycle({
             ? allowedValues.indexOf(value) === allowedValues.length - 1
               ? required
                 ? allowedValues[0]
-                : null
+                : undefined
               : allowedValues[allowedValues.indexOf(value) + 1]
             : allowedValues[0],
         )

diff --git a/website/pages-parts/CustomFields/RatingField.tsx b/website/pages-parts/CustomFields/RatingField.tsx
@@ -22,7 +22,8 @@ function Rating({
           style={{ fontSize: 40, cursor: 'pointer' }}
           key={index}
           onClick={() =>
-            disabled || onChange(!required && value === index ? null : index)
+            disabled ||
+            onChange(!required && value === index ? undefined : index)
           }
         >
           {index <= value ? '★' : '☆'}