Backport: # 2870 Fix Java Serialization warnings for Tuple #2869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrnSaurabh
changed the title
pivovarit
reviewed
Sep 30, 2024
| @@ -1953,7 +1953,7 @@ def generateMainClasses(): Unit = { | |||
| /$javadoc | |||
| * The ${j.ordinal} element of this tuple. | |||
| */ | |||
| public final T$j _$j; | |||
| transient public T$j _$j; | |||
There was a problem hiding this comment.
transient means that you want to ignore field during serialization - tuple elements can't be ignored.
We also want them final.
There was a problem hiding this comment.
Indeed. The transient modifier will likely break other serialization libraries, too.
There was a problem hiding this comment.
There is an implementation added in this class for readObject() and writeObject() to explicitly serialize and deserialize these fields so that they are not ignored.
|
I've taken care of Tuples here: #2872, feel free to have a look at the rest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #2870