Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scala to 3.5 #2857

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Update Scala to 3.5 #2857

merged 1 commit into from
Sep 29, 2024

Conversation

achinaou
Copy link
Contributor

Made the minimal changes to update Scala to 3.5 and fix the resulting issues.

@achinaou achinaou requested a review from pivovarit as a code owner September 29, 2024 04:16
@achinaou
Copy link
Contributor Author

achinaou commented Sep 29, 2024

I started by migrating from Ammonite to using Scala directly, as the 3.5+ versions use the Scala CLI as the default runner, which provides more functionality. But, this led to a larger download size and more complex build script.

I think it would make sense to pay the penalty if Scala was used more extensively in the project and there was a need for more functionality than just running a script.

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (e43e44b) to head (092f5ed).
Report is 61 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2857      +/-   ##
============================================
+ Coverage     92.74%   92.76%   +0.01%     
- Complexity     5247     5259      +12     
============================================
  Files            89       89              
  Lines         12538    12542       +4     
  Branches       1604     1595       -9     
============================================
+ Hits          11628    11634       +6     
  Misses          721      721              
+ Partials        189      187       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pivovarit
Copy link
Member

Thanks! Amazing work! It was on my list as well, but I postponed it because it seemed like way more work 🙈

@pivovarit pivovarit merged commit 7fe4a23 into vavr-io:master Sep 29, 2024
8 checks passed
@pivovarit pivovarit mentioned this pull request Sep 29, 2024
pivovarit pushed a commit that referenced this pull request Sep 29, 2024
@achinaou
Copy link
Contributor Author

I also was expecting it to be more complicated...

It's nice for a change to overestimate a task! 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants