Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkedHashMap.put(existing key) should keep order #1838 #1988

Merged
merged 1 commit into from
May 10, 2017

Conversation

ruslansennov
Copy link
Member

@ruslansennov ruslansennov commented May 10, 2017

Fixes #1838

@codecov-io
Copy link

Codecov Report

Merging #1988 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1988      +/-   ##
============================================
+ Coverage     97.77%   97.78%   +0.01%     
+ Complexity     5164     5163       -1     
============================================
  Files            91       91              
  Lines         11795    11793       -2     
  Branches       1566     1566              
============================================
  Hits          11532    11532              
+ Misses          116      115       -1     
+ Partials        147      146       -1
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/io/vavr/collection/LinkedHashMap.java 98.51% <100%> (-0.02%) 127 <2> (-2)
...r/src/main/java/io/vavr/concurrent/FutureImpl.java 85% <0%> (+2.5%) 22% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1647ce0...f6b8f61. Read the comment docs.

Copy link
Contributor

@danieldietrich danieldietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for the fast PR!!

@danieldietrich danieldietrich merged commit 87c5853 into vavr-io:master May 10, 2017
@danieldietrich danieldietrich added this to the vavr-0.9.0 milestone May 10, 2017
@ruslansennov ruslansennov deleted the lhm-order2 branch May 10, 2017 07:08
@yuriykulikov
Copy link

You guys are awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants