Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-server, xo-web): fix install patches and RPU on XS8 #8241

Merged
merged 8 commits into from
Jan 22, 2025

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Jan 10, 2025

Description

Fix Forum#9550, zammad#28805, zammad#28411, zammad#30349
To make things simpler, RPU will apply the full level of patches not just mandatory

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@MathieuRA MathieuRA force-pushed the xs-8-install-updates branch 2 times, most recently from ee71660 to 4f0644c Compare January 13, 2025 13:11
@MathieuRA MathieuRA marked this pull request as ready for review January 13, 2025 13:50
@MathieuRA MathieuRA self-assigned this Jan 13, 2025
@MathieuRA MathieuRA requested a review from b-Nollet January 13, 2025 13:50
@MathieuRA MathieuRA changed the title WIP: install patches on XS8 fix(xo-server, xo-web): fix install patches and RPU on XS8 Jan 13, 2025
@b-Nollet b-Nollet requested a review from fbeauchamp January 14, 2025 15:03
@xen-orchestra/xapi/vm.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/xapi/mixins/patching.mjs Outdated Show resolved Hide resolved
@MathieuRA MathieuRA force-pushed the xs-8-install-updates branch from 4703923 to 4c9fb3c Compare January 20, 2025 14:19
@MathieuRA MathieuRA requested a review from b-Nollet January 20, 2025 16:00
@b-Nollet b-Nollet requested a review from fbeauchamp January 21, 2025 09:09
@MathieuRA MathieuRA force-pushed the xs-8-install-updates branch from 3582134 to 89ac9ff Compare January 22, 2025 13:42
@MathieuRA MathieuRA merged commit 9af5818 into master Jan 22, 2025
1 check passed
@MathieuRA MathieuRA deleted the xs-8-install-updates branch January 22, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants