Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-server/signin): temporary design matching XO 6 color palette #8209

Merged
merged 6 commits into from
Dec 20, 2024

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Dec 20, 2024

Screenshots


Description

Short explanation of this PR (feel free to re-use commit message)

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@pdonias pdonias requested a review from MathieuRA December 20, 2024 14:04
@julien-f
Copy link
Member

Love it! ❤️

@julien-f
Copy link
Member

Maybe too much space around the logo? 🤔

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@pdonias
Copy link
Member Author

pdonias commented Dec 20, 2024

@julien-f You mean between the logo and the text?

@pdonias pdonias requested a review from MathieuRA December 20, 2024 14:30
@pdonias pdonias force-pushed the pierre-xo6-signin-page branch from b8a134d to 25ae55b Compare December 20, 2024 14:30
@MathieuRA MathieuRA merged commit 22f9b35 into master Dec 20, 2024
1 check passed
@MathieuRA MathieuRA deleted the pierre-xo6-signin-page branch December 20, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants