Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-server/xo-web): in host advanced tab, display mdadm status #8190

Merged
merged 9 commits into from
Dec 20, 2024

Conversation

MelissaFrncJrg
Copy link
Contributor

@MelissaFrncJrg MelissaFrncJrg commented Dec 12, 2024

Description

Fixes #7634
mdadm-status-advanced-view
mdadm-status-host-view

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@MelissaFrncJrg MelissaFrncJrg marked this pull request as ready for review December 12, 2024 16:59
packages/xo-server/src/xapi/index.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/xapi/index.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/xapi/index.mjs Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/home/host-item.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/home/host-item.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/host/tab-advanced.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/host/tab-advanced.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/host/tab-advanced.js Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-server/src/api/host.mjs Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias December 16, 2024 15:16
@MathieuRA

This comment was marked as resolved.

packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-server/src/xapi/index.mjs Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-server/src/api/host.mjs Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/host/tab-advanced.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/host/tab-advanced.js Outdated Show resolved Hide resolved
@xen-orchestra/xapi/host.mjs Outdated Show resolved Hide resolved
@MelissaFrncJrg MelissaFrncJrg requested review from MathieuRA and removed request for MathieuRA December 19, 2024 15:23
@MelissaFrncJrg MelissaFrncJrg force-pushed the host/displayMdadmStatus branch from daa11ed to 25c9e29 Compare December 19, 2024 15:35
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@MelissaFrncJrg MelissaFrncJrg force-pushed the host/displayMdadmStatus branch from 9ebc9fe to 2ff7a67 Compare December 19, 2024 15:54
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/host/tab-advanced.js Outdated Show resolved Hide resolved
@pdonias pdonias merged commit c41ae05 into master Dec 20, 2024
1 check passed
@pdonias pdonias deleted the host/displayMdadmStatus branch December 20, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose mdadm status in host/advanced
3 participants