Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web): add rolling pool reboot and update to the plannable jobs #8185

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Dec 10, 2024

Description

adding rolling pool reboot and rooling pool reboot to the list of schedulable/chainable jobs.
selecitonning multiple pools will reboot them in parallel

image

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@fbeauchamp
Copy link
Collaborator Author

rolling pull reboot tested

@fbeauchamp fbeauchamp force-pushed the feat_schedule_rpu_rpr branch from 05512d4 to 02fc173 Compare December 10, 2024 16:47
@fbeauchamp fbeauchamp marked this pull request as ready for review December 10, 2024 16:47
@fbeauchamp fbeauchamp requested a review from b-Nollet December 11, 2024 14:19
@fbeauchamp fbeauchamp merged commit 4a54685 into master Dec 13, 2024
1 check passed
@fbeauchamp fbeauchamp deleted the feat_schedule_rpu_rpr branch December 13, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants