Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-server): in proxies tab, display current version #8104

Merged
merged 6 commits into from
Nov 18, 2024

Conversation

MelissaFrncJrg
Copy link
Contributor

Description

Featured asked by @Fohdeesha: display the current proxy version without having to use cli commands
image

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@MelissaFrncJrg MelissaFrncJrg marked this pull request as ready for review November 5, 2024 13:25
@MathieuRA MathieuRA removed their request for review November 6, 2024 09:46
packages/xo-server/src/xo-mixins/proxies.mjs Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/proxies/index.js Outdated Show resolved Hide resolved
packages/xo-server/src/xo-mixins/proxies.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/xo-mixins/proxies.mjs Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from fbeauchamp November 7, 2024 13:57
CHANGELOG.unreleased.md Show resolved Hide resolved
packages/xo-server/src/xo-mixins/proxies.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/xo-mixins/proxies.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/xo-mixins/proxies.mjs Show resolved Hide resolved
Copy link
Collaborator

@fbeauchamp fbeauchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to add a comment to validate this review, but mathieu already said everything

@fbeauchamp fbeauchamp merged commit 9939cee into master Nov 18, 2024
1 check passed
@fbeauchamp fbeauchamp deleted the displayProxyVersion branch November 18, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants