fix(backups): remove snapshot data only after the transfer is finished #7828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbeauchamp
changed the title
fbeauchamp
force-pushed
the
fix_snapshot_deletion
branch
from
c38947c to
fefffd5
Compare
b-Nollet
approved these changes
Jul 19, 2024
b-Nollet
reviewed
Jul 19, 2024
julien-f
force-pushed
the
fix_snapshot_deletion
branch
2 times, most recently
from
199d175 to
9613116
Compare
* _removeUnusedSnapshots is called before and after the backup * in some case it can delete the snapshot data before the transfer is done
julien-f
force-pushed
the
fix_snapshot_deletion
branch
from
9613116 to
1a0b82d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ensure the purge data on snapshot is only called after backup transfer is completly done , since removeunusedsnapshot is called before and after transfer
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.md