-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(xo-web/backup): add 'report recipients' when creating a metadata backup #7776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some testing, the email does not seem to be sent correctly.
You also need to add some changes in the xo-server-backup-reports
plugin.
// packages/xo-server-backup-reports/src/index.js
Class BackupReportsXoPlugin {
...
async _metadataHandler(log, { name: jobName, settings }, schedule, force) {
const xo = this._xo
const mailReceivers = get(() => settings[''].reportRecipients)
...
return this._sendReport({
...
mailReceivers,
})
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase then OK for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase to resolve conflicts in xo-server-backup-reports
8a4805a
to
95f14f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am getting a task.tasks is not iterable
error. Do you reproduce?
No errors on my side |
32c092b
to
05d1f46
Compare
Fixed. |
05d1f46
to
02e68b9
Compare
f93d937
to
37eb8a5
Compare
37eb8a5
to
22e5bfc
Compare
Description
Do not squash
Fixes #7569
![image](https://private-user-images.githubusercontent.com/119158464/343195300-27a5385c-d8fe-42bf-9a19-101c093646d8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzOTExMjAsIm5iZiI6MTczOTM5MDgyMCwicGF0aCI6Ii8xMTkxNTg0NjQvMzQzMTk1MzAwLTI3YTUzODVjLWQ4ZmUtNDJiZi05YTE5LTEwMWMwOTM2NDZkOC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQyMDA3MDBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wNjYxZTE3ZjYzYWYwOGZhZWY2OGVhZGUwZDJlODVhOTdiODI5NDcwYjlmZmJkNWRlN2E3YjI0OTQ1YzUzMzhlJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.0yxAsSK-8U1zcsJQg3VZmSAh_6_BPdfY3jL9zJsq9VU)
Checklist
Fixes #007
,See xoa-support#42
,See https://...
)Introduced by
CHANGELOG.unreleased.md