Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vmxware-explorer): vsan detection #7717

Merged
merged 2 commits into from
Jun 5, 2024
Merged

fix(vmxware-explorer): vsan detection #7717

merged 2 commits into from
Jun 5, 2024

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Jun 3, 2024 •
edited
Loading

Description

Fixes zammad#25110
introduced by 2d07fdc

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@fbeauchamp fbeauchamp force-pushed the fix_vsan_detection branch from d23ec6e to 2626d4b Compare June 3, 2024 07:51
@fbeauchamp fbeauchamp requested a review from b-Nollet June 3, 2024 07:52
@fbeauchamp fbeauchamp marked this pull request as ready for review June 3, 2024 07:52
@b-Nollet b-Nollet requested a review from julien-f June 3, 2024 07:56
julien-f
julien-f reviewed Jun 3, 2024
View reviewed changes
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the commit introducing this bug.

@fbeauchamp fbeauchamp force-pushed the fix_vsan_detection branch from 2626d4b to e684933 Compare June 4, 2024 12:30
@fbeauchamp fbeauchamp requested a review from julien-f June 4, 2024 12:30
@julien-f julien-f merged commit 58cc1de into master Jun 5, 2024
1 check failed
@julien-f julien-f deleted the fix_vsan_detection branch June 5, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-Nollet b-Nollet b-Nollet approved these changes

@julien-f julien-f Awaiting requested review from julien-f

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fbeauchamp @julien-f @b-Nollet