Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(netbox): sync XO users as Netbox tenants #7158

Merged
merged 4 commits into from
Nov 14, 2023
Merged

feat(netbox): sync XO users as Netbox tenants #7158

merged 4 commits into from
Nov 14, 2023

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Nov 6, 2023 •
edited
Loading

See Zammad#11356
See Zammad#17364
See Zammad#18409

Screenshots

Capture_2023-11-06_17:36:41
Capture_2023-11-06_17:18:16

Description

Optionally:

  • synchronize XO users as Netbox tenants
  • link a tenant to a Netbox VM if the user is the XO VM's creator

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@pdonias pdonias force-pushed the pierre-netbox-tenants branch 2 times, most recently from 17332dc to c2c1a0b Compare November 7, 2023 09:33
@pdonias pdonias changed the title feat(netbox): use Netbox version instead of Netbox API version feat(netbox): sync XO users as Netbox tenants Nov 7, 2023
@pdonias pdonias force-pushed the pierre-netbox-tenants branch 2 times, most recently from be4db78 to 71e910c Compare November 9, 2023 08:55
@pdonias pdonias marked this pull request as ready for review November 9, 2023 08:56
@pdonias pdonias requested a review from MathieuRA November 9, 2023 08:56
@pdonias pdonias force-pushed the pierre-netbox-tenants branch 2 times, most recently from e5a761f to 957ff36 Compare November 9, 2023 09:20
@pdonias
feat(netbox): sync XO users as Netbox tenants
681009b 
See Zammad#11356
See Zammad#17364
See Zammad#18409
@pdonias pdonias force-pushed the pierre-netbox-tenants branch from 957ff36 to 681009b Compare November 9, 2023 09:21
@MathieuRA MathieuRA requested a review from julien-f November 10, 2023 10:45
@pdonias pdonias requested a review from julien-f November 14, 2023 09:25
@julien-f julien-f requested a review from MathieuRA November 14, 2023 09:27
@MathieuRA
Copy link
Member

@julien-f , Resolve your comment please.

@julien-f
Copy link
Member

@MathieuRA Done. Sorry about that :)

@MathieuRA
Copy link
Member

@pdonias Rebase on master to fix CHANGELOG conflicts, then good to me.

@MathieuRA MathieuRA merged commit 7af0899 into master Nov 14, 2023
@MathieuRA MathieuRA deleted the pierre-netbox-tenants branch November 14, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-f julien-f julien-f approved these changes

@MathieuRA MathieuRA MathieuRA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdonias @MathieuRA @julien-f