Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-server): implement disk status check #7060

Merged
merged 3 commits into from
Sep 28, 2023
Merged

feat(xo-server): implement disk status check #7060

merged 3 commits into from
Sep 28, 2023

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Sep 28, 2023 •
edited by MathieuRA
Loading

Screenshot

Capture d’écran de 2023-09-28 16-59-04
Capture d’écran de 2023-09-28 10-49-08
Capture d’écran de 2023-09-28 10-55-57

Description

See #4458

expose disk status check from plugin https://github.com/xcp-ng/xcp-ng-xapi-plugins#smartctl-parser by @AtaxyaNetwork

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MathieuRA MathieuRA requested a review from pdonias September 28, 2023 09:47
@MathieuRA MathieuRA marked this pull request as ready for review September 28, 2023 09:47
pdonias
pdonias requested changes Sep 28, 2023
View reviewed changes
packages/xo-server/src/api/host.mjs Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/host/tab-advanced.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/host/tab-advanced.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias September 28, 2023 13:59
@pdonias pdonias requested a review from julien-f September 28, 2023 14:08
julien-f
julien-f reviewed Sep 28, 2023
View reviewed changes
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Server side is good enough for me.

CHANGELOG.unreleased.md Show resolved Hide resolved
@MathieuRA MathieuRA force-pushed the feat_smartctl branch 2 times, most recently from 8484283 to 36c18fc Compare September 28, 2023 14:53
@MathieuRA MathieuRA requested a review from julien-f September 28, 2023 14:58
@julien-f
Copy link
Member

@MathieuRA Please resolve conflicts with master.

@MathieuRA
Copy link
Member

@julien-f Done

@julien-f julien-f merged commit 0e934c1 into master Sep 28, 2023
@julien-f julien-f deleted the feat_smartctl branch September 28, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivierlambert olivierlambert olivierlambert left review comments

@julien-f julien-f julien-f approved these changes

@pdonias pdonias pdonias approved these changes

Assignees
No one assigned
Labels
Highlight
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fbeauchamp @julien-f @MathieuRA @olivierlambert @pdonias