fix(xo-server/normalizeVmNetworks): always assume multiple space-delimited IPs #6990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathieuRA
requested changes
Aug 24, 2023
Co-authored-by: Mathieu <[email protected]>
julien-f
force-pushed
the
pierre-fix-addresses
branch
from
7f8019d to
21d18c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://xcp-ng.org/forum/topic/7625
Description
The previous code assumed that only legacy
x/ipfields could contain multiple space-delimited IPs but it turns out that it can also happen inx/ipvx/xfields (see link).When it happened, the IPs weren't flattened and it could break the Netbox synchronization, which assumes that the IPs are properly flattened.
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.md