feat(backups): deduplication #6929
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbeauchamp
force-pushed
the
feat_dedup
branch
8 times, most recently
from
103fe3d to
8f76708
Compare
julien-f
reviewed
Jul 6, 2023
@xen-orchestra/fs/src/dedupLocal.js
Outdated
| import assert from 'node:assert' | ||
| import { createHash } from 'node:crypto' | ||
|
|
||
| export default class DedupedLocalHandler extends LocalHandler { |
julien-f
reviewed
Jul 6, 2023
@xen-orchestra/fs/src/dedupLocal.js
Outdated
|
|
||
| async _sync() { | ||
| await super._sync() | ||
| await this.mkdir(this.#dedupFolder) |
There was a problem hiding this comment.
I think it should only be created when necessary.
julien-f
reviewed
Jul 6, 2023
@xen-orchestra/fs/src/dedupLocal.js
Outdated
There was a problem hiding this comment.
Create a function to garbage collect orphaned files in the dedup store.
It will be used via xo-fs CLI and should be documented in a small doc @xen-orchestra/backups/docs/dedup.md.
julien-f
reviewed
Jul 6, 2023
@xen-orchestra/fs/src/dedupLocal.js
Outdated
| import { createHash } from 'node:crypto' | ||
|
|
||
| export default class DedupedLocalHandler extends LocalHandler { | ||
| #dedupFolder = '/xo-block-store' |
fbeauchamp
force-pushed
the
feat_dedup
branch
3 times, most recently
from
1cb7901 to
a6376bc
Compare
fbeauchamp
force-pushed
the
feat_dedup
branch
6 times, most recently
from
6174c22 to
50f378e
Compare
fbeauchamp
force-pushed
the
feat_dedup
branch
from
862d9a6 to
df96930
Compare
fbeauchamp
commented
Nov 18, 2024
| @@ -285,7 +293,7 @@ exports.VhdDirectory = class VhdDirectory extends VhdAbstract { | |||
| } | |||
|
|
|||
| async writeEntireBlock(block) { | |||
| await this._writeChunk(this.#getBlockPath(block.id), block.buffer) | |||
| await this._writeChunk(this.#getBlockPath(block.id), block.buffer, this.#dedup) | |||
There was a problem hiding this comment.
should use the right flag to ensure we don't overwrite silently, since we'll have to check old block for deletion before
fbeauchamp
force-pushed
the
feat_dedup
branch
from
df96930 to
48db60d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.md