Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backups): fix CR not deleting older VM #6871

Merged
merged 3 commits into from
Jun 1, 2023
Merged

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Jun 1, 2023

Description

scheduleId was not passed to the writers constructor. It leads to missing scheduleId in metadata (I think there is no consequence), and a bad filter to detect VM to delete after a successfull replication

Users may need to delete manually the VM created that way

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@fbeauchamp fbeauchamp marked this pull request as ready for review June 1, 2023 07:24
@fbeauchamp fbeauchamp requested a review from julien-f June 1, 2023 07:27
@julien-f julien-f requested a review from ggunullu June 1, 2023 07:33
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
Co-authored-by: Julien Fontanet <[email protected]>
@julien-f julien-f merged commit b18ebcc into master Jun 1, 2023
@julien-f julien-f deleted the fix_cr_delete_oldentries branch June 1, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants