Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-web): XO Tasks #6861

Merged
merged 4 commits into from
May 30, 2023
Merged

feat(xo-web): XO Tasks #6861

merged 4 commits into from
May 30, 2023

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented May 25, 2023

Screenshots

Capture_2023-05-25_10:35:07

Description

Expose XO Tasks in the UI

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@pdonias pdonias requested a review from julien-f May 25, 2023 12:32
@julien-f julien-f requested a review from ByScripts May 25, 2023 13:37
julien-f
julien-f requested changes May 25, 2023
View reviewed changes
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/tasks/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Show resolved Hide resolved
@pdonias pdonias marked this pull request as ready for review May 26, 2023 09:06
julien-f
julien-f requested changes May 26, 2023
View reviewed changes
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic is sound regarding tasks and subscription.

@pdonias pdonias merged commit 92fd92a into master May 30, 2023
@pdonias pdonias deleted the pierre-xo-tasks branch May 30, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ByScripts ByScripts ByScripts approved these changes

@julien-f julien-f julien-f approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdonias @ByScripts @julien-f