Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backups): implements mirror backups backend #6854

Merged
merged 2 commits into from
May 30, 2023
Merged

feat(backups): implements mirror backups backend #6854

merged 2 commits into from
May 30, 2023

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented May 23, 2023 •
edited
Loading

Description

Implement mirror backup in the backend (copy a remote / backup repository to another remote)
review by commit

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@fbeauchamp fbeauchamp mentioned this pull request May 23, 2023
Closed
@fbeauchamp fbeauchamp force-pushed the feat_mirror_backup branch 4 times, most recently from 833c9e1 to 31b2454 Compare May 23, 2023 14:06
@fbeauchamp fbeauchamp marked this pull request as ready for review May 24, 2023 07:42
@fbeauchamp fbeauchamp force-pushed the feat_mirror_backup branch from 276acf9 to 3113c47 Compare May 24, 2023 08:02
@fbeauchamp fbeauchamp requested a review from julien-f May 24, 2023 08:05
julien-f
julien-f reviewed May 24, 2023
View reviewed changes
@xen-orchestra/backups/_runners/VmsXapi.js Outdated Show resolved Hide resolved
@xen-orchestra/backups/RemoteAdapter.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA mentioned this pull request May 26, 2023
Merged
@julien-f julien-f force-pushed the feat_mirror_backup branch from d36152c to 9fe4ae0 Compare May 26, 2023 10:55
@julien-f julien-f force-pushed the feat_mirror_backup branch from 9fe4ae0 to 0332b9e Compare May 26, 2023 11:02
@fbeauchamp fbeauchamp force-pushed the feat_mirror_backup branch 5 times, most recently from 5acc336 to 04f049c Compare May 29, 2023 13:31
@fbeauchamp
Copy link
Collaborator Author

fbeauchamp commented May 29, 2023 •
edited
Loading

Integration tests with PR #6854

  • backup works
  • backup mirror works
  • job creation, edition , deletion works
  • job running works
  • job log are ok-ish

To discuss/fix :

  • no size shown in the log
    image
  • Are you sure you want to run incremental (b7012)? This job will backup 0 VMs. is a confusing confirmation message

@fbeauchamp fbeauchamp force-pushed the feat_mirror_backup branch from 04f049c to 855ed72 Compare May 29, 2023 13:41
@fbeauchamp fbeauchamp requested a review from julien-f May 29, 2023 13:42
@julien-f julien-f force-pushed the feat_mirror_backup branch from 855ed72 to 22d4ef0 Compare May 30, 2023 09:04
@fbeauchamp fbeauchamp force-pushed the feat_mirror_backup branch 2 times, most recently from 3d572c1 to c203c06 Compare May 30, 2023 09:58
@fbeauchamp fbeauchamp requested a review from julien-f May 30, 2023 09:59
@julien-f julien-f force-pushed the feat_mirror_backup branch 2 times, most recently from 736f1b9 to 7a59e37 Compare May 30, 2023 13:18
@julien-f julien-f force-pushed the feat_mirror_backup branch from 7a59e37 to 4ee91c0 Compare May 30, 2023 13:21
@julien-f julien-f merged commit 8b7b162 into master May 30, 2023
@julien-f julien-f deleted the feat_mirror_backup branch May 30, 2023 13:21
pdonias pushed a commit that referenced this pull request May 31, 2023
@MathieuRA
feat(xo-web/backup): UI mirror backup implementation (#6858)
ee0adae 
See #6854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathieuRA MathieuRA MathieuRA left review comments

@julien-f julien-f Awaiting requested review from julien-f

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fbeauchamp @julien-f @MathieuRA